<p>In <a href="https://github.com/mlpack/mlpack/pull/747#discussion_r74704736">src/mlpack/methods/neighbor_search/knn_main.cpp</a>:</p>
<pre style='color:#555'>&gt; +      double effectiveError = 0;
&gt; +      size_t cases = 0;
&gt; +      for (size_t i = 0; i &lt; distances.n_elem; i++)
&gt; +      {
&gt; +        if (distancesExact(i) != 0 &amp;&amp; distances(i) != DBL_MAX)
&gt; +        {
&gt; +          effectiveError += (distances(i) - distancesExact(i)) /
&gt; +              distancesExact(i);
&gt; +          cases++;
&gt; +        }
&gt; +      }
&gt; +      if (cases)
&gt; +        effectiveError /= cases;
&gt; +
&gt; +      Log::Info &lt;&lt; &quot;Effective error: &quot; &lt;&lt; effectiveError &lt;&lt; endl;
&gt; +    }
</pre>
<p>Do you think it would be better to move the effective relative error calculation into the <code>NeighborSearch</code> class, perhaps as a static method?  You could pass in the two distance matrices as input and get the effective relative error as output.  That way people could reuse this functionality elsewhere.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r74704736">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFGMAJsRTEXfEZ7DQuTvMNi8_s1Etks5qf0KMgaJpZM4JZzLU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFOwjr0CiQvy1G7EMvQCqjSXRFwYXks5qf0KMgaJpZM4JZzLU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r74704736"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #747: Do you think it would be better to move the effective relative error calculation into the `NeighborSearch` class, perhaps as a static method?  You could pass in the two distance matrices as input and get the effective relative error as output.  That way people could reuse this functionality elsewhere."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r74704736"}}}</script>