<p>In <a href="https://github.com/mlpack/mlpack/pull/749#discussion_r74690150">src/mlpack/methods/lsh_model/lshmodel_impl.hpp</a>:</p>
<pre style='color:#555'>&gt; +  // If not specified by user, set these to the ones we trained for.
&gt; +  if (numProjIn == 0)
&gt; +    numProjOut = this-&gt;numProj;
&gt; +
&gt; +  if (numTablesIn == 0)
&gt; +    numTablesOut = this-&gt;numTables;
&gt; +
&gt; +  if (hashWidthOut == 0.0)
&gt; +    hashWidthOut = this-&gt;hashWidth;
&gt; +
&gt; +  LSHSearch&lt;&gt; lsh(*referenceSet, numProjOut, numTablesOut, hashWidthOut,
&gt; +      secondHashSize, bucketSize);
&gt; +
&gt; +  lshObjectVector.push_back(lsh);
&gt; +
&gt; +  return lshObjectVector[lshObjectVector.size() - 1];
</pre>
<p>Why are you preserving the LSH objects you create?  It seems to me that they aren't used anywhere else.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/749/files/cdcb575826bfb3bd0ef4cafacf465435b3d6d144#r74690150">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFACwgWfy7xlEAHVtKZTN0DQnR8b0ks5qfgdTgaJpZM4JczVR">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFJ32OP3ImQgAJuL1Cszy6LJgSxduks5qfgdTgaJpZM4JczVR.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/749/files/cdcb575826bfb3bd0ef4cafacf465435b3d6d144#r74690150"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #749: Why are you preserving the LSH objects you create?  It seems to me that they aren't used anywhere else."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/749/files/cdcb575826bfb3bd0ef4cafacf465435b3d6d144#r74690150"}}}</script>