<p>In <a href="https://github.com/mlpack/mlpack/pull/760#discussion_r74682180">src/mlpack/core/tree/hrectbound_impl.hpp</a>:</p>
<pre style='color:#555'>&gt;    }
&gt;  
&gt;    // Now take the Power&#39;th root (but make sure our result is squared if it needs
&gt;    // to be); then cancel out the constant of 2 (which may have been squared now)
&gt;    // that was introduced earlier.  The compiler should optimize out the if
&gt;    // statement entirely.
&gt; -  if (MetricType::TakeRoot)
&gt; -    return (ElemType) pow((double) sum, 1.0 / (double) MetricType::Power) / 2.0;
&gt; +  if (MetricType::Power == 1)
&gt; +    return sum * 0.5;
&gt; +  else if (MetricType::Power == 2)
&gt; +  {
&gt; +    if (MetricType::TakeRoot)
&gt; +      return std::sqrt(sum) * 0.5;
</pre>
<p>I've forgotten to ask about this piece of code:<br>
<code>pow((double) sum, 1.0 / (double) MetricType::Power)</code></p>

<p>Do you use the conversion in order to increase precision or you just take care of integral data types?</p>

<p>Should I replace <code>std::sqrt(sum)</code> by <code>(ElemType) std::sqrt((double) sum)</code>?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/760/files/8e6223ce9cbc05b5cb68e6f4e7a96d8cb41bf5ff..55e15792e4dc2135c6e3421c5dae1322d07b0dcc#r74682180">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFFaJAkG_80_ucK6IrsEEIIKUkF8Cks5qfVdXgaJpZM4JjVKx">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFJEJVkUeDqVfKg_PEmXbtyw9i8ELks5qfVdXgaJpZM4JjVKx.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/760/files/8e6223ce9cbc05b5cb68e6f4e7a96d8cb41bf5ff..55e15792e4dc2135c6e3421c5dae1322d07b0dcc#r74682180"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@lozhnikov in #760: I've forgotten to ask about this piece of code:\r\n` pow((double) sum, 1.0 / (double) MetricType::Power)`\r\n\r\nDo you use the conversion in order to increase precision or you just take care of integral data types?\r\n\r\nShould I replace `std::sqrt(sum)` by `(ElemType) std::sqrt((double) sum)`?"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/760/files/8e6223ce9cbc05b5cb68e6f4e7a96d8cb41bf5ff..55e15792e4dc2135c6e3421c5dae1322d07b0dcc#r74682180"}}}</script>