<p><a href="https://github.com/lozhnikov" class="user-mention">@lozhnikov</a> yes! I agree that there is no error.  I meant to say that it was a bit confusing not using a hyperplane there.... because Random Projection Trees seems to be based on splitting hyperplanes. But, I am sure they have their reasons!<br>
It becomes a bit difficult to generalize some concepts when we implement many differents flavours! :)<br>
So, I think we can consider both PR separately, and once they are merged with the master branch we can see if it is possible to unify both implementations of the splitting algorithms, to avoid duplicated code. Would you agree?<br>
Thanks!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/726#issuecomment-238134502">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFGMylUX9jBtnkszuVZXXm69aG0OZks5qdqKQgaJpZM4JOuGE">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFBKun-vDwjy6x9fom6jrVdD_qkMeks5qdqKQgaJpZM4JOuGE.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/726#issuecomment-238134502"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/modules/aws/aws-bg.jpg","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MarcosPividori in #726: @lozhnikov yes! I agree that there is no error.  I meant to say that it was a bit confusing not using a hyperplane there.... because Random Projection Trees seems to be based on splitting hyperplanes. But, I am sure they have their reasons!\r\nIt becomes a bit difficult to generalize some concepts when we implement many differents flavours! :)\r\nSo, I think we can consider both PR separately, and once they are merged with the master branch we can see if it is possible to unify both implementations of the splitting algorithms, to avoid duplicated code. Would you agree?\r\nThanks!"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/726#issuecomment-238134502"}}}</script>