<p>In <a href="https://github.com/mlpack/mlpack/pull/747#discussion_r73787567">src/mlpack/core/tree/spill_tree/spill_tree_impl.hpp</a>:</p>
<pre style='color:#555'>> + left->ParentDistance() = leftParentDistance;
> + right->ParentDistance() = rightParentDistance;
> +}
> +
> +template<typename MetricType,
> + typename StatisticType,
> + typename MatType,
> + template<typename HyperplaneMetricType> class HyperplaneType,
> + template<typename SplitMetricType, typename SplitMatType>
> + class SplitType>
> +bool SpillTree<MetricType, StatisticType, MatType, HyperplaneType, SplitType>::
> + SplitPoints(const double tau,
> + const double rho,
> + const std::vector<size_t>& points,
> + std::vector<size_t>& leftPoints,
> + std::vector<size_t>& rightPoints)
</pre>
<p><a href="https://github.com/rcurtin" class="user-mention">@rcurtin</a> Yes, I agree. You are right, this can make a difference for big datasets.<br>
I have updated the code in: <a href="https://github.com/mlpack/mlpack/pull/747/commits/071588457415094e99883774af541075e3858c22" class="commit-link"><tt>0715884</tt></a><br>
Thanks!</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/747/files/a71b57caa90311f5542180bc0553449c3691395d#r73787567">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFPewsW5IGVWW9MR2NU1gY_v02iO7ks5qdKeNgaJpZM4JZzLU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFMMSq_cJaTd1cjqpy6jSbJ3iWreuks5qdKeNgaJpZM4JZzLU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/747/files/a71b57caa90311f5542180bc0553449c3691395d#r73787567"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/modules/aws/aws-bg.jpg","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MarcosPividori in #747: @rcurtin Yes, I agree. You are right, this can make a difference for big datasets.\r\nI have updated the code in: https://github.com/mlpack/mlpack/pull/747/commits/071588457415094e99883774af541075e3858c22\r\nThanks!"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/747/files/a71b57caa90311f5542180bc0553449c3691395d#r73787567"}}}</script>