<p>In <a href="https://github.com/mlpack/mlpack/pull/751#discussion_r73780117">src/mlpack/core/dists/gamma_distribution.cpp</a>:</p>
<pre style='color:#555'>> + // Compute probability using Multiplication Law.
> + probabilities(i) *=
> + std::pow(observations(d, i), alpha(d) - 1) *
> + std::exp(-observations(d, i) / beta(d)) /
> + denominators(d);
> + }
> + }
> +}
> +
> +// Returns the probability of one observation (x) for one of the Gamma's
> +// dimensions.
> +double GammaDistribution::Probability(double x, size_t dim) const
> +{
> + return
> + std::pow(x, alpha(dim) - 1) * std::exp(-x / beta(dim)) /
> + (std::tgamma(alpha(dim)) * std::pow(beta(dim), alpha(dim)));
</pre>
<p>I know I'm being picky but I think the indentation needs to be one more here. Another option is to split this into multiple lines for readability, but that's up to you. Realistically, to the compiler, it shouldn't make a difference if you compute a bunch of doubles then multiply them together, or compute the result all at once.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/751/files/9cb117f671f55186baddf38ce71107a2a3ae027f#r73780117">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFBgGzixIUyU1se-FClnZXOglzUHMks5qdACBgaJpZM4Jd7IK">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFGiiA6pp1k7JOFCn5X7JuUpm6ZMLks5qdACBgaJpZM4Jd7IK.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/751/files/9cb117f671f55186baddf38ce71107a2a3ae027f#r73780117"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/modules/aws/aws-bg.jpg","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #751: I know I'm being picky but I think the indentation needs to be one more here. Another option is to split this into multiple lines for readability, but that's up to you. Realistically, to the compiler, it shouldn't make a difference if you compute a bunch of doubles then multiply them together, or compute the result all at once."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/751/files/9cb117f671f55186baddf38ce71107a2a3ae027f#r73780117"}}}</script>