<p>Woow! a minute! This pull request seems to implement something very similar to what I have implemented for spill trees: <a href="https://github.com/mlpack/mlpack/pull/747/commits/9588a6dd63154481f0442e087bde0e640d02ec7f" class="commit-link"><tt>9588a6d</tt></a><br>
When splitting the nodes according to the values in a given projection. I think we should merge both implementations.<br>
In my commit I implement an abstraction: ProjectionVector and Hyperplane. And use SpaceSplit class to split the nodes according to their projection.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/726#issuecomment-237865271">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFPUEYtuzWoKX3kxiG2a1m5xGh_tCks5qc0iLgaJpZM4JOuGE">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFPzP_8_YBVvT0mPljEX30mdUeUWJks5qc0iLgaJpZM4JOuGE.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/726#issuecomment-237865271"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/modules/aws/aws-bg.jpg","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MarcosPividori in #726: Woow! a minute! This pull request seems to implement something very similar to what I have implemented for spill trees: https://github.com/mlpack/mlpack/pull/747/commits/9588a6dd63154481f0442e087bde0e640d02ec7f\r\nWhen splitting the nodes according to the values in a given projection. I think we should merge both implementations.\r\nIn my commit I implement an abstraction: ProjectionVector and Hyperplane. And use SpaceSplit class to split the nodes according to their projection."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/726#issuecomment-237865271"}}}</script>