<p>In <a href="https://github.com/mlpack/mlpack/pull/751#discussion_r73780142">src/mlpack/core/dists/gamma_distribution.cpp</a>:</p>
<pre style='color:#555'>&gt; +      // Compute probability using Multiplication Law and Logarithm addition
&gt; +      // property.
&gt; +      LogProbabilities(i) += std::log( 
&gt; +        std::pow(observations(d, i), alpha(d) - 1) 
&gt; +        * std::exp(-observations(d, i) / beta(d)) 
&gt; +        / denominators(d));
&gt; +    }
&gt; +  }
&gt; +}
&gt; +
&gt; +// Returns a gamma-random d-dimensional vector.
&gt; +arma::vec GammaDistribution::Random() const
&gt; +{
&gt; +  arma::vec randVec(alpha.n_elem);
&gt; +
&gt; +  std::default_random_engine generator;
</pre>
<p>I think you should use <code>mlpack::math::randGen</code> here instead, so that if the user sets the random seed, the results when they call <code>GammaDistribution::Random()</code> are deterministic.  (<code>randGen</code> is defined in <code>mlpack/core/math/random.hpp</code>.)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/751/files/9cb117f671f55186baddf38ce71107a2a3ae027f#r73780142">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFAX-rNJJNqEAN20jehbsnab4QP3Kks5qdAEPgaJpZM4Jd7IK">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFFrLsVgfHQvf4n7EnYHDMHu0Q7Ejks5qdAEPgaJpZM4Jd7IK.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/751/files/9cb117f671f55186baddf38ce71107a2a3ae027f#r73780142"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/modules/aws/aws-bg.jpg","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #751: I think you should use `mlpack::math::randGen` here instead, so that if the user sets the random seed, the results when they call `GammaDistribution::Random()` are deterministic.  (`randGen` is defined in `mlpack/core/math/random.hpp`.)"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/751/files/9cb117f671f55186baddf38ce71107a2a3ae027f#r73780142"}}}</
 script>