<p>In <a href="https://github.com/mlpack/mlpack/pull/748#discussion_r73315110">src/mlpack/core/dists/gamma_distribution.cpp</a>:</p>
<pre style='color:#555'>&gt; +    Train(logMeanx, meanLogx, meanx, tol);
&gt; +
&gt; +    // The function above modifies the state of this object. Get the parameters
&gt; +    // it fit. (This is not very good design...).
&gt; +    tempAlpha(row) = alpha(0);
&gt; +    tempBeta(row) = beta(0);
&gt; +  }
&gt; +  alpha = tempAlpha;
&gt; +  beta = tempBeta;
&gt; +
&gt; +}
&gt; +
&gt; +// Fits an alpha and beta parameter to each dimension of the data.
&gt; +void GammaDistribution::Train(const double logMeanx, const double meanLogx,
&gt; +                              const double meanx,
&gt; +                              const double tol)
</pre>
<p>You're right - I was concerned with my design using temps and having two functions changing the vectors continuously. What you propose is cleaner. Thanks :)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/748/files/09a90ee81a8ae3b69be94d8f84ff32794af2b7d6#r73315110">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFPGzOnLFrrVH3vq-L7p-zZB-5Dk5ks5qcHFXgaJpZM4Jaqw0">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFOttT9kBSMH5wZtfH30qYNEkutghks5qcHFXgaJpZM4Jaqw0.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/748/files/09a90ee81a8ae3b69be94d8f84ff32794af2b7d6#r73315110"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/modules/aws/aws-bg.jpg","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mentekid in #748: You're right - I was concerned with my design using temps and having two functions changing the vectors continuously. What you propose is cleaner. Thanks :)"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/748/files/09a90ee81a8ae3b69be94d8f84ff32794af2b7d6#r73315110"}}}</script>