<p>In <a href="https://github.com/mlpack/mlpack/pull/742#discussion_r72757986">src/mlpack/methods/preprocess/preprocess_describe_main.cpp</a>:</p>
<pre style='color:#555'>> + double S4 = pow(rowStd, 4);
> + double norm3 = (3 * (n-1) * (n-1)) / ((n-2) * (n-3));
> + double normC = (n * (n+1))/((n-1) * (n-2) * (n-3));
> + double normM = M4 / S4;
> + kurtosis = normC * normM - norm3;
> + }
> + return kurtosis;
> +}
> +/**
> + * Calculates standard error of standard deviation.
> + *
> + * @param input Vector that captures a dimension of a dataset
> + * @param rowStd Standard Deviation of the given vector.
> + * @return Standard error of the stanrdard devation of the given vector.
> + */
> +double StandardError(const arma::rowvec& input, const double rowStd)
</pre>
<p>I think we could replace rowvec by size_t, because this could reduce dependency on specific type.<br>
In medium or large size project, reduce dependency of your api can make your codes easier to maintain.</p>
<p>ps : This is not a big problem in this small CLI program</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/742/files/27ac82e876c3d68637d9e72d28bf0dadbc229ace#r72757986">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFO9hkufgxRWN78m5uMnZuHaYfPOHks5qabpRgaJpZM4JWax8">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFA3OMmXuzcob5PvwcqDM50Jh2QdOks5qabpRgaJpZM4JWax8.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/742/files/27ac82e876c3d68637d9e72d28bf0dadbc229ace#r72757986"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>