<p>In <a href="https://github.com/mlpack/mlpack/pull/741#discussion_r72461768">src/mlpack/core/tree/binary_space_tree/midpoint_split_impl.hpp</a>:</p>
<pre style='color:#555'>> }
> }
>
> delete[] ranges;
> }
>
> + assert(splitVal != DBL_MAX);
> +
> if (maxWidth == 0) // All these points are the same. We can't split.
> return false;
</pre>
<p>Hm, I think we could avoid the assert here (or handle it better) if we just made the conditional <code>if (maxWidth <= 0)</code>; what do you think? Then no split would be performed.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/741/files/a659b90e57931d0377167cb980602ed565b44536#r72461768">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFJLAKxLFi-WcylOpFLsKRbH3YKQuks5qZ3kAgaJpZM4JWS3I">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFFBacsQJhfO4ta6ti4AB1hNausEVks5qZ3kAgaJpZM4JWS3I.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/741/files/a659b90e57931d0377167cb980602ed565b44536#r72461768"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>