<p>In <a href="https://github.com/mlpack/mlpack/pull/708#discussion_r71899891">src/mlpack/core/tree/vantage_point_tree/dual_tree_traverser_impl.hpp</a>:</p>
<pre style='color:#555'>> + if (rightScore != DBL_MAX)
> + {
> + // Restore the right traversal info.
> + rule.TraversalInfo() = traversalInfo;
> + Traverse(queryNode, *referenceNode.Right());
> + }
> + else
> + ++numPrunes;
> + }
> + }
> + }
> + else
> + {
> + // If the reference node contains a point we should calculate all
> + // base cases with this point.
> + if (referenceNode.IsFirstPointCentroid())
</pre>
<p>Ah hang on, but we could end up with duplicated base cases like this. Let me think for a while if there might be a better way to avoid duplications but preserve this type of technique. Maybe you are right that traversing with a query node and a reference point could work, but that would require a lot of refactoring of all the dual-tree algorithms so I'd prefer to avoid that...</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/708/files/300882ac96e7a663e3e303ca0c45c14c6fafe1a6#r71899891">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFJHMITRmDhNQm5Hm09oe-RavjB3sks5qYOUIgaJpZM4I_COp">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFIB1wDju6pXxqQ-LKJMxsqKbPPyEks5qYOUIgaJpZM4I_COp.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/708/files/300882ac96e7a663e3e303ca0c45c14c6fafe1a6#r71899891"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>