<p>In <a href="https://github.com/mlpack/mlpack/pull/694#discussion_r71920523">src/mlpack/core/data/imputation_methods/listwise_deletion.hpp</a>:</p>
<pre style='color:#555'>> + }
> +
> + /**
> + * Impute function searches through the input looking for mappedValue and
> + * remove the whole row or column. The result is overwritten to the input.
> + *
> + * @param input Matrix that contains mappedValue.
> + * @param mappedValue Value that the user wants to get rid of.
> + * @param dimension Index of the dimension of the mappedValue.
> + * @param columnMajor State of whether the input matrix is columnMajor or not.
> + */
> + void Impute(arma::Mat<T>& input,
> + const T& mappedValue,
> + const size_t dimension,
> + const bool columnMajor = true)
> + {
</pre>
<p>Now I see what do you mean, yah, it do have lot of redundancy codes. We should be able to get rid of them by using the single input api </p>
<pre><code>inline
void Impute(const arma::Mat<T>& input,
arma::Mat<T>& output,
const T& mappedValue,
const size_t dimension,
const bool columnMajor = true)
{
// initiate output
output.set_size(input.n_rows, input.n_cols);
Impute(output, mappedValue, dimension, columnMajor);
}
</code></pre>
<p>Last time it was implemented as</p>
<pre><code>inline
void Impute(const arma::Mat<T>& input,
arma::Mat<T>& output,
const T& mappedValue,
const size_t dimension,
const bool columnMajor = true)
{
// initiate output
output = input;
Impute(output, mappedValue, dimension, columnMajor);
}
</code></pre>
<p>Haven't noticed the new change generate duplicate codes, my fault</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/694/files/028c217057410e2e75691c32bf062202ce5dca3f#r71920523">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFGpOhYHLCr3xrveN3XrKBu7wIjIpks5qYQaagaJpZM4I07W-">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFA3RTrL6GLzge8sfZLNeKmOoM5e6ks5qYQaagaJpZM4I07W-.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/694/files/028c217057410e2e75691c32bf062202ce5dca3f#r71920523"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>