<p>In <a href="https://github.com/mlpack/mlpack/pull/708#discussion_r71805911">src/mlpack/core/tree/vantage_point_tree/vantage_point_split.hpp</a>:</p>
<pre style='color:#555'>> + */
> + static void GetDistinctSamples(arma::uvec& distinctSamples,
> + const size_t numSamples, const size_t begin, const size_t upperBound);
> +
> + /**
> + * Get the median value of the distance from a certain vantage point to a
> + * number of samples.
> + *
> + * @param bound The bound used for this node.
> + * @param data The dataset used by the binary space tree.
> + * @param samples The indices of random samples.
> + * @param vantagePoint The vantage point.
> + * @param mu The median value.
> + */
> + static void GetMedian(const BoundType& bound, const MatType& data,
> + const arma::uvec& samples, const size_t vantagePoint, ElemType& mu);
</pre>
<p>I think here and in <code>GetSecondMoment()</code>, it would be better to pass a <code>MetricType</code> instead of a <code>BoundType</code>.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/708/files/300882ac96e7a663e3e303ca0c45c14c6fafe1a6#r71805911">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFLyC4gdzNl0zBgtm8PWPJOZfh9FTks5qYAEdgaJpZM4I_COp">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFPrH8GuPuKuXW_0IKbHbDLcIIlZCks5qYAEdgaJpZM4I_COp.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/708/files/300882ac96e7a663e3e303ca0c45c14c6fafe1a6#r71805911"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>