<p>In <a href="https://github.com/mlpack/mlpack/pull/694#discussion_r71076241">src/mlpack/tests/imputation_test.cpp</a>:</p>
<pre style='color:#555'>> + BOOST_REQUIRE(std::isnan(output(2, 1)) == true); // remains as NaN
> + BOOST_REQUIRE_CLOSE(output(2, 2), 10.0, 1e-5);
> +
> + // Remove the file.
> + remove("test_file.csv");
> +}
> +
> +/**
> + * Make sure a CSV is loaded correctly.
> + */
> +BOOST_AUTO_TEST_CASE(CustomImputationTest)
> +{
> + arma::mat input("3.0 0.0 2.0 0.0;"
> + "5.0 6.0 0.0 6.0;"
> + "9.0 8.0 4.0 8.0;");
> + arma::mat outputT; // assume input is transposed
</pre>
<p>This comment is a little bit confuse since the name of the parameter already change to columnMajor, we can use a bool value to tell the readers the output is columnMajor or rowMajor.</p>
<p>ex : </p>
<pre><code>bool columnMajor = true;
CustomImputation<double> imputer(customValue);
imputer.Impute(input, outputT, mappedValue, 0/*dimension*/, columnMajor );
</code></pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/694/files/e5d591e511ae449eae1523a80346357b93b968d1#r71076241">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFFp6cNajT4HITufyUd4FGBq4cuwBks5qWazFgaJpZM4I07W-">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFKtEezwrThNzIgXeQln7rnL5Arlaks5qWazFgaJpZM4I07W-.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/694/files/e5d591e511ae449eae1523a80346357b93b968d1#r71076241"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>