<p>In <a href="https://github.com/mlpack/mlpack/pull/720#discussion_r70496924">CMakeLists.txt</a>:</p>
<pre style='color:#555'>> + find_program(LCOV lcov)
> +
> + if(NOT GCOV)
> + message(FATAL_ERROR "gcov not found! Aborting...")
> + endif()
> +
> + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --coverage -fno-inline -fno-inline-small-functions -fno-default-inline -fprofile-arcs -fkeep-inline-functions")
> + message(WARNING "Adding debug options for coverage")
> + # Remove optimizations for better line coverage
> + set(DEBUG ON)
> +
> + if(LCOV)
> + configure_file(CMake/mlpack_coverage.in mlpack_coverage @ONLY)
> + add_custom_target(mlpack_coverage DEPENDS mlpack_test COMMAND ${PROJECT_BINARY_DIR}/mlpack_coverage)
> + else()
> + message(WARNING "'lcov' not found, local coverage report is disabled. Install 'lcov' and rerun cmake to generate local coverage report.")
</pre>
<p>I think maybe this one should be <code>FATAL_ERROR</code>: if the user builds intentionally with <code>BUILD_WITH_COVERAGE=ON</code>, then I assume they would expect to use <code>mlpack_coverage</code> afterwards. But if they don't see this warning, then they will type <code>make mlpack_coverage</code> and it won't work, and they will end up confused. What do you think?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/720/files/ff02cb500867c83c848d69c3f85c5004b1d9fb4a#r70496924">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFPgIFhjM7Tawb95Z9IqjciyQpO-2ks5qU9-WgaJpZM4JJw9X">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFBwnJEWoq31u-5sbJ-B84jPXcLJUks5qU9-WgaJpZM4JJw9X.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/720/files/ff02cb500867c83c848d69c3f85c5004b1d9fb4a#r70496924"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>