<p>I replaced <code>SortStruct</code> by <code>std::pair</code> in the R* tree and the X tree and fixed some compiler warnings about uninitialized variables. I did some tests, <code>std::pair</code> provides some speedups in <code>mlpack_knn</code> for the R* tree and the X tree.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>&nbsp;&nbsp;<a href='https://github.com/mlpack/mlpack/pull/721'>https://github.com/mlpack/mlpack/pull/721</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Replace SortStruct by std::pair</li>
  <li>Fix compiler warnings</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/721/files#diff-0">src/mlpack/core/tree/rectangle_tree/r_plus_tree_split_impl.hpp</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/721/files#diff-1">src/mlpack/core/tree/rectangle_tree/r_star_tree_split.hpp</a>
    (20)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/721/files#diff-2">src/mlpack/core/tree/rectangle_tree/r_star_tree_split_impl.hpp</a>
    (266)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/721/files#diff-3">src/mlpack/core/tree/rectangle_tree/x_tree_split.hpp</a>
    (21)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/721/files#diff-4">src/mlpack/core/tree/rectangle_tree/x_tree_split_impl.hpp</a>
    (295)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/721/files#diff-5">src/mlpack/methods/adaboost/adaboost_impl.hpp</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/721/files#diff-6">src/mlpack/methods/ann/layer/one_hot_layer.hpp</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/721/files#diff-7">src/mlpack/methods/ann/layer/vr_class_reward_layer.hpp</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/721/files#diff-8">src/mlpack/methods/perceptron/perceptron_impl.hpp</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/721/files#diff-9">src/mlpack/methods/radical/radical.cpp</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/mlpack/mlpack/pull/721.patch'>https://github.com/mlpack/mlpack/pull/721.patch</a></li>
  <li><a href='https://github.com/mlpack/mlpack/pull/721.diff'>https://github.com/mlpack/mlpack/pull/721.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/721">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFJNDiADaCx6p-ZPpLtSRHUqfkBUSks5qU44zgaJpZM4JKXF9">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFEP1ZJpGqlrGvA9UKO8efOGh-yW_ks5qU44zgaJpZM4JKXF9.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/721"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>