<p>In <a href="https://github.com/mlpack/mlpack/pull/694#discussion_r69914587">src/mlpack/core/data/dataset_info_impl.hpp</a>:</p>
<pre style='color:#555'>> + {
> + std::ostringstream oss;
> + oss << "DatasetMapper<PolicyType>::UnmapValue(): string '" << string
> + << "' unknown for dimension " << dimension;
> + throw std::invalid_argument(oss.str());
> + }
> +
> + return maps[dimension].first.left.at(string);
> +}
> +
> +template<typename PolicyType>
> +template<typename eT>
> +inline void DatasetMapper<PolicyType>::MapTokens(
> + const std::vector<std::string>& tokens,
> + size_t& row,
> + arma::Mat<eT>& matrix)
</pre>
<p>The tabbing here seems weird, if you put the arguments on a new line, they should only be two tabs in from the original indentation. I think this comment applies to some other methods in this PR too.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/694/files/a8818316a04506530e2269a2e0a32ba2f6a1c83b#r69914587">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFNIbxEsFfBsdkL7HfOrG8G0ctEq-ks5qTQqKgaJpZM4I07W-">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFBDqT8ESHkhP-W2PJqtamBXO0uLGks5qTQqKgaJpZM4I07W-.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/694/files/a8818316a04506530e2269a2e0a32ba2f6a1c83b#r69914587"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>