<p>I found some weird errors in the Hilbert R tree implementation. I fixed them in <a href="https://github.com/mlpack/mlpack/commit/05fbd27221931f20975e139f4984e5e05a11487f" class="commit-link"><tt>05fbd27</tt></a>.<br>
Moreover, I added the Hilbert R tree to (NS, RS, RA)Model and (A)KNNTest, RangeSearchTest and KRANNTest.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/mlpack/mlpack/pull/710'>https://github.com/mlpack/mlpack/pull/710</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Some Hilbert R tree fixes</li>
<li>Added the Hilbert R tree to NSModel</li>
<li>Added the Hilbert R tree to RSModel</li>
<li>Added the Hilbert R tree to RAModel</li>
<li>Added the Hilbert R tree to (A)KNNTest, RangeSearchTest and KRANNTest.</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-0">src/mlpack/core/tree/rectangle_tree/discrete_hilbert_value.hpp</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-1">src/mlpack/core/tree/rectangle_tree/discrete_hilbert_value_impl.hpp</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-2">src/mlpack/core/tree/rectangle_tree/hilbert_r_tree_auxiliary_information.hpp</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-3">src/mlpack/core/tree/rectangle_tree/hilbert_r_tree_auxiliary_information_impl.hpp</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-4">src/mlpack/methods/neighbor_search/kfn_main.cpp</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-5">src/mlpack/methods/neighbor_search/knn_main.cpp</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-6">src/mlpack/methods/neighbor_search/ns_model.hpp</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-7">src/mlpack/methods/neighbor_search/ns_model_impl.hpp</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-8">src/mlpack/methods/range_search/range_search_main.cpp</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-9">src/mlpack/methods/range_search/rs_model.cpp</a>
(21)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-10">src/mlpack/methods/range_search/rs_model.hpp</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-11">src/mlpack/methods/range_search/rs_model_impl.hpp</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-12">src/mlpack/methods/rann/krann_main.cpp</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-13">src/mlpack/methods/rann/ra_model.hpp</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-14">src/mlpack/methods/rann/ra_model_impl.hpp</a>
(56)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-15">src/mlpack/tests/aknn_test.cpp</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-16">src/mlpack/tests/knn_test.cpp</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-17">src/mlpack/tests/krann_search_test.cpp</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/710/files#diff-18">src/mlpack/tests/range_search_test.cpp</a>
(12)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/mlpack/mlpack/pull/710.patch'>https://github.com/mlpack/mlpack/pull/710.patch</a></li>
<li><a href='https://github.com/mlpack/mlpack/pull/710.diff'>https://github.com/mlpack/mlpack/pull/710.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/710">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFMe3bAlRKqfCM_h0SrnF9q3FbQDiks5qQTNpgaJpZM4JALZo">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFPCDgux-bsPistlnsqr6bui0XLuuks5qQTNpgaJpZM4JALZo.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/710"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>