<p>In <a href="https://github.com/mlpack/mlpack/pull/691#discussion_r68645742">src/mlpack/methods/lsh/lsh_search_impl.hpp</a>:</p>
<pre style='color:#555'>> - arma::rowvec hashVec = secondHashWeights.t() * arma::floor(allProjInTables);
> + queryCodesNotFloored.unsafe_col(i) = projections.slice(i).t() * queryPoint;
> + queryCodesNotFloored += offsets.cols(0, numTablesToSearch - 1);
> + allProjInTables = arma::floor(queryCodesNotFloored/hashWidth);
> +
> +
> + // Use hashMat to store the primary probing codes and any additional codes
> + // from multiprobe LSH.
> + arma::Mat<size_t> hashMat;
> + hashMat.set_size(T + 1, numTablesToSearch);
> +
> + // Compute the primary hash value of each key of the query into a bucket of
> + // the secondHashTable using the secondHashWeights.
> + hashMat.row(0) =
> + arma::conv_to< arma::Row<size_t> >:: // floor by typecasting to size_t
> + from( secondHashWeights.t() * allProjInTables );
</pre>
<p>I think this could fit a bit more concisely on one (or probably two) lines; there's no need for the spaces between the <code><></code> and there are extra spaces after <code>from(</code> and before the closing <code>);</code>.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/691/files/71eda99e207a9b91581504e11a9e14d38838bc9f#r68645742">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFFdC6jhVO5NA3SZ8y9NQSGKbhiZ3ks5qQCzggaJpZM4IxQW5">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFAnFD3DUrNYvcuoTP9_npnwTKx-Dks5qQCzggaJpZM4IxQW5.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/691/files/71eda99e207a9b91581504e11a9e14d38838bc9f#r68645742"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>