<p>In <a href="https://github.com/mlpack/mlpack/pull/691#discussion_r68645229">src/mlpack/methods/lsh/lsh_search_impl.hpp</a>:</p>
<pre style='color:#555'>> + std::vector<bool> Ai;
> + do
> + {
> + // Get the perturbation set corresponding to the minimum score.
> + Ai = perturbationSets[ minHeap.top().second ];
> + minHeap.pop(); // .top() returns, .pop() removes
> +
> + // Shift operation on Ai (replace max with max+1).
> + std::vector<bool> As = Ai;
> + if ( perturbationShift(As) && perturbationValid(As, numProj) )
> + // Don't add invalid sets.
> + {
> + perturbationSets.push_back(As); // add shifted set to sets
> + minHeap.push(
> + std::make_pair(
> + perturbationScore(As, scores),
</pre>
<p>It's fine to indent this after the <code>make_pair</code> is already indented, but I would go an additional four spaces in if you are going to do that. Personally, here, I would just do this:</p>
<pre><code>minHeap.push(std::make_pair(perturbationScore(As, scores),
perturbationSets.size() - 1));
</code></pre>
<p>(I doubt that will line up right, but the idea is to line up <code>perturbationScore(As, scores)</code> with <code>perturbationSets.size() - 1</code>, and, no need to have an extra line to close the whole thing.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/691/files/71eda99e207a9b91581504e11a9e14d38838bc9f#r68645229">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFOZ30n0-PTG26XqmSIQSVJ23crYjks5qQCwPgaJpZM4IxQW5">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFA2Q6SVb_fUCQ9oZHfM6Uee2-SRpks5qQCwPgaJpZM4IxQW5.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/691/files/71eda99e207a9b91581504e11a9e14d38838bc9f#r68645229"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>