<p>In <a href="https://github.com/mlpack/mlpack/pull/691#discussion_r68060454">src/mlpack/methods/lsh/lsh_search_impl.hpp</a>:</p>
<pre style='color:#555'>> for (size_t i = 0; i < hashVec.n_elem; i++)
> hashVec[i] = (double) ((size_t) hashVec[i] % secondHashSize);
>
> Log::Assert(hashVec.n_elem == numTablesToSearch);
>
> + // Compute hashVectors of additional probing bins
> + arma::mat hashMat;
</pre>
<p><strong>On your first point:</strong> I wondered too when I first saw this - I thought it had something to do with operator precedence but <a href="http://en.cppreference.com/w/c/language/operator_precedence">typecasting precedes modding</a>, so I'm fixing that.</p>
<p><strong>On your second point:</strong> In the beginning I started doing it like that to avoid the copy, but the armadillo spans confused me so I went around it. I'll try to find a way to do it the way you say.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/691/files/fa7f62da6a4cfe7fa45e297d7a4a1491c9c39bb1#r68060454">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFLYivDNQ0YHX_2wF2u2vOybvDXqyks5qOUODgaJpZM4IxQW5">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFBx-uACYk7OgF0a_rBy8jaRGh1X5ks5qOUODgaJpZM4IxQW5.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/691/files/fa7f62da6a4cfe7fa45e297d7a4a1491c9c39bb1#r68060454"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>