<p>In <a href="https://github.com/mlpack/mlpack/pull/664#discussion_r67959939">src/mlpack/core/tree/rectangle_tree/discrete_hilbert_value.hpp</a>:</p>
<pre style='color:#555'>> + void Copy(TreeType* dst, TreeType* src);
> +
> + void NullifyData();
> +
> + /**
> + * Update the largest Hilbert value and the local dataset.
> + * The children of the node (or the points that the node contains) should be
> + * arranged according to their Hilbert values.
> + * @param node The node in which the information should be updated.
> + */
> + template<typename TreeType>
> + void UpdateLargestValue(TreeType* node);
> +
> + template<typename TreeType>
> + void UpdateHilbertValues(TreeType* parent, size_t firstSibling,
> + size_t lastSibling);
</pre>
<p>You are right, <code>UpdateLargestValue</code> is used in order to update the largest Hilbert value of all parent nodes after a point is added to a leaf node. I think my approach requires less memory and copying of a pointer takes less time, isn't it?.</p>
<p>Since the split methods redistributes all points contained in leaf nodes completely, I need a function in order to redistribute the Hilbert values of the points. I wrote <code>UpdateHilbertValues</code> in order to do that. Maybe I should call that function <code>RedistributeHilbertValues</code>, how do you think?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/664/files/f9127cea62d5ce1ad8d5f59931de108a2f7cdd9b#r67959939">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFObVcIZ329EYT1P0uwgTolIJ8G77ks5qOF5ggaJpZM4IrlzT">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFJp6jFx0lVo0VlF3lgo6m6up80Fsks5qOF5ggaJpZM4IrlzT.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/664/files/f9127cea62d5ce1ad8d5f59931de108a2f7cdd9b#r67959939"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>