<p>In <a href="https://github.com/mlpack/mlpack/pull/664#discussion_r67934409">src/mlpack/core/tree/rectangle_tree/discrete_hilbert_value.hpp</a>:</p>
<pre style='color:#555'>> + void Copy(TreeType* dst, TreeType* src);
> +
> + void NullifyData();
> +
> + /**
> + * Update the largest Hilbert value and the local dataset.
> + * The children of the node (or the points that the node contains) should be
> + * arranged according to their Hilbert values.
> + * @param node The node in which the information should be updated.
> + */
> + template<typename TreeType>
> + void UpdateLargestValue(TreeType* node);
> +
> + template<typename TreeType>
> + void UpdateHilbertValues(TreeType* parent, size_t firstSibling,
> + size_t lastSibling);
</pre>
<p>I am not sure I understand what these functions do or how they are used... do you think you could update the documentation?</p>
<p>I think that <code>UpdateLargestValue</code> is used after a point is added to a node, to update the <code>DiscreteHilbertValue</code> object of all parent nodes so that the largest Hilbert value stored by any descendant is in <code>localDataset</code>. Is that correct? In that case, would it maybe be better to resize the <code>localDataset</code> of the parent node to just one element and store the largest Hilbert value there? I am not sure of the full structure, so maybe my comments are wrong, but I am having a hard time understanding.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/664/files/f9127cea62d5ce1ad8d5f59931de108a2f7cdd9b#r67934409">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFKoVstaV-DrEo2rftLzd-GLJzXDcks5qODmCgaJpZM4IrlzT">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFHmFaBPUM3-63WSNiMsy2S5tqHMGks5qODmCgaJpZM4IrlzT.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/664/files/f9127cea62d5ce1ad8d5f59931de108a2f7cdd9b#r67934409"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>