<p>In <a href="https://github.com/mlpack/mlpack/pull/664#discussion_r67792069">src/mlpack/core/tree/rectangle_tree/discrete_hilbert_value_impl.hpp</a>:</p>
<pre style='color:#555'>&gt; +    ownsLocalDataset(false),
&gt; +    numValues(0),
&gt; +    valueToInsert(tree-&gt;Parent() ? 
&gt; +                tree-&gt;Parent()-&gt;AuxiliaryInfo().HilbertValue().ValueToInsert() :
&gt; +                new arma::Col&lt;HilbertElemType&gt;(tree-&gt;Dataset().n_rows)),
&gt; +    ownsValueToInsert(tree-&gt;Parent() ? false : true)
&gt; +{
&gt; +  // Calculate the Hilbert value for all points
&gt; +  if (!tree-&gt;Parent()) //  This is the root node
&gt; +    ownsLocalDataset = true;
&gt; +  else if (tree-&gt;Parent()-&gt;Children()[0]-&gt;IsLeaf())
&gt; +  {
&gt; +    // This is a leaf node
&gt; +    assert(tree-&gt;Parent()-&gt;NumChildren() &gt; 0);
&gt; +    ownsLocalDataset = true;
&gt; +  }
</pre>
<p>I agree that <code>hilbertValues</code> is a better name. But I think that <code>localDataset</code> works fine and since we decided that we should add something like <code>InsertPoints()</code> into <code>RectangleTree</code> we have to update <code>hilbertValues</code> on each insertion/deletion. Right now <code>localDataset</code> does not require that. What do you think about it?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/664/files/f9127cea62d5ce1ad8d5f59931de108a2f7cdd9b#r67792069">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFDbMizJ-asXfttXcEyVWrSmM0p4Uks5qNzP0gaJpZM4IrlzT">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFK20Unl3wb_UAeWz-oHIN1uxH9vqks5qNzP0gaJpZM4IrlzT.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/664/files/f9127cea62d5ce1ad8d5f59931de108a2f7cdd9b#r67792069"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>