<p>In <a href="https://github.com/mlpack/mlpack/pull/696#discussion_r67095481">src/mlpack/methods/edge_boxes/feature_extraction.hpp</a>:</p>
<pre style='color:#555'>> + MatType DistanceTransformImage(MatType const &im, double on);
> +
> + arma::field<CubeType> GetFeatures(MatType const &image, arma::umat &loc);
> +
> + CubeType CopyMakeBorder(CubeType const &InImage, size_t top,
> + size_t left, size_t bottom, size_t right);
> +
> + void GetShrunkChannels(CubeType const &InImage, CubeType &reg_ch, CubeType &ss_ch);
> +
> + CubeType RGB2LUV(CubeType const &InImage);
> +
> + MatType bilinearInterpolation(MatType const &src,
> + size_t height, size_t width);
> +
> + CubeType sepFilter2D(CubeType &InOutImage, arma::vec &kernel,\
> + size_t radius);
</pre>
<p>Even the names of int, double variables? Also by camel casing do you mean "outImage" or "OutImage". I don't mind making changes however minor they are. Code needs to be perfect.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/696/files/b38b688edfc4c2ee8bf461240f8384a70575d3a4#r67095481">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFOhswBhublXisIvpliIbph-un8AFks5qL3RAgaJpZM4I1lnr">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFJQFDWz7PDcwZ-cs2ZANDlORcSRrks5qL3RAgaJpZM4I1lnr.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/696/files/b38b688edfc4c2ee8bf461240f8384a70575d3a4#r67095481"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>