<p>In <a href="https://github.com/mlpack/mlpack/pull/683#discussion_r66487517">src/mlpack/methods/edge_boxes/feature_extraction_impl.hpp</a>:</p>
<pre style='color:#555'>> + for(size_t j = 0; j < mag.n_cols; ++j)
> + {
> + double max = -9999999999.0; int max_loc = 0;
> + for(size_t k = 0; k < mag.n_slices; ++k)
> + {
> + if(mag(i, j, k) > max)
> + {
> + max = mag(i, j, k);
> + MaxVal(i, j) = max;
> + Location(i, j) = k;
> + }
> + }
> + }
> + }
> + return MaxVal;
> +}
</pre>
<p>Maybe we can vectorize the codes?</p>
<pre><code>//pseudo codes
arma::uvec location = location = arma::find(mag.slice(0) > mag.slice(1));
MaxVal.elem(location == 1) = mag.slice(1).elem(location == 1);
</code></pre>
<p>We can optimize this part after the prototype can work :)</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/683/files/9d85b64c6c6bdff608331195351d09abf56cfc96#r66487517">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFH3feHp2-ZpGAEyd_mRahins9D32ks5qKFEhgaJpZM4IvUrl">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFJthe8BiQtikxtvSPBrmKxrjC7-Dks5qKFEhgaJpZM4IvUrl.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/683/files/9d85b64c6c6bdff608331195351d09abf56cfc96#r66487517"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>