<p>In <a href="https://github.com/mlpack/mlpack/pull/683#discussion_r66461047">src/mlpack/methods/edge_boxes/feature_extraction_impl.hpp</a>:</p>
<pre style='color:#555'>> + if (this->options["rgbd"] == 0)
> + n_color_ch = 3;
> + else
> + n_color_ch = 4;
> +
> + n_grad_ch = 2 * (1 + this->options["n_orient"]);
> +
> + n_ch = n_color_ch + n_grad_ch;
> + P[0] = pow((p_size / shrink) , 2) * n_ch;
> + P[1] = pow(n_cell , 2) * (pow (n_cell, 2) - 1) / 2 * n_ch;
> + return P;
> +}
> +
> +template<typename MatType, typename CubeType>
> +arma::vec StructuredForests<MatType, CubeType>::
> +dt_1d(arma::vec& f, int n)
</pre>
<p>f looks like a candidate for const too, besides, mlpack api like to add const before primitive too.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/683/files/9d85b64c6c6bdff608331195351d09abf56cfc96#r66461047">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFEhuJ4wzBu5w7rNZrH2coBL8LQJ4ks5qKC6AgaJpZM4IvUrl">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFJyPZMFmf3MSIHb_pR7uuNqjxeuzks5qKC6AgaJpZM4IvUrl.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/683/files/9d85b64c6c6bdff608331195351d09abf56cfc96#r66461047"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>