<p>In <a href="https://github.com/mlpack/mlpack/pull/686#discussion_r66160291">src/mlpack/methods/ne/genome.hpp</a>:</p>
<pre style='color:#555'>> +
> + // Loop neurons to calculate neurons' activation.
> + for (unsigned in j=aNumInput; j<aNeuronGenes.size(); ++j) {
> + double x = aNeuronGenes[j].aInput; // TODO: consider bias. Difference?
> + aNeuronGenes[j].aInput = 0;
> +
> + double y = 0;
> + switch (aNeuronGenes[j].Type()) { // TODO: revise the implementation.
> + case SIGMOID: // TODO: more cases.
> + y = sigmoid(x);
> + break;
> + case RELU:
> + y = relu(x);
> + break;
> + default:
> + y = sigmoid(x);
</pre>
<p>I don't think it's a good idea, to reimplement the activation function or to keep a copy in the ne module. For a couple of reasons:</p>
<ul>
<li>it would increase maintenance</li>
<li>if there is a bug in one of the activation functions we probably have to fix the same activation function twice</li>
<li>we have to rewrite the tests that are already existing for all ann activation functions</li>
<li>if we implement a non-existing activation function for one of the evolution methods, we can also use the function for the ann modules</li>
</ul>
<p>Also, since we have this neat update policy, we don't go and change API's between two versions. So if we change something there should be enough time, for adaptation.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/686/files/3c8aa62b951f029b3883e9baef1ea556ef5af2d3#r66160291">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFPT7WbjQMFy8tpTXqWHmFs9MNtbIks5qJejogaJpZM4IwJa6">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFOM45cKVXlChTUbTnofaMdv9vGgyks5qJejogaJpZM4IwJa6.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/686/files/3c8aa62b951f029b3883e9baef1ea556ef5af2d3#r66160291"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>