<p>In <a href="https://github.com/mlpack/mlpack/pull/686#discussion_r66150677">src/mlpack/methods/ne/genome.hpp</a>:</p>
<pre style='color:#555'>> +
> + // Loop neurons to calculate neurons' activation.
> + for (unsigned in j=aNumInput; j<aNeuronGenes.size(); ++j) {
> + double x = aNeuronGenes[j].aInput; // TODO: consider bias. Difference?
> + aNeuronGenes[j].aInput = 0;
> +
> + double y = 0;
> + switch (aNeuronGenes[j].Type()) { // TODO: revise the implementation.
> + case SIGMOID: // TODO: more cases.
> + y = sigmoid(x);
> + break;
> + case RELU:
> + y = relu(x);
> + break;
> + default:
> + y = sigmoid(x);
</pre>
<p>Do you think it is a good idea to make our implementation of activation functions the same with <br>
<a href="https://github.com/mlpack/mlpack/tree/master/src/mlpack/methods/ann/activation_functions">https://github.com/mlpack/mlpack/tree/master/src/mlpack/methods/ann/activation_functions</a><br>
but keep it in our own ne folder? So that if the functions in ann module changes, it won't affect the ne module. Besides, we can add more functions in ne module without change ann code.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/686/files/3c8aa62b951f029b3883e9baef1ea556ef5af2d3#r66150677">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFOWksXduLax2Jp8foUPn2hjaiMOMks5qJdppgaJpZM4IwJa6">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFD0d5ewDH25sM0UR7QcclVQRu1Clks5qJdppgaJpZM4IwJa6.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/686/files/3c8aa62b951f029b3883e9baef1ea556ef5af2d3#r66150677"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>