Here's what I have in mind regarding an std::vector<size_t> array.<br>
<br>
This requires more work, but let me know what you think.<br>
<br>
If you run this with default parameters it will probably take a lot of<br>
time, that's because the old implementation discards a lot of points while<br>
this way we don't discard any.<br>
<br>
We could also implement an optional size limit for the vectors for backward<br>
compatibility, for example set the default to actually be 500 points but if<br>
you set bucketSize to 0 the vectors grow arbitrarily large.<br>
<br>
On Sat, Jun 4, 2016 at 3:43 AM, Ryan Curtin <notifications@github.com><br>
wrote:<br>
<br>
> I had fun rewriting it too, just ran out of time for now to test it. :)<br>
><br>
> —<br>
> You are receiving this because you were mentioned.<br>
> Reply to this email directly, view it on GitHub<br>
> <https://github.com/mlpack/mlpack/pull/675#issuecomment-223725394>, or mute<br>
> the thread<br>
> <https://github.com/notifications/unsubscribe/AFxX3Co0w7vNpLCoCljOORwjhzLR2yQvks5qIMopgaJpZM4IuAcT><br>
> .<br>
><br>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/675#issuecomment-223760088">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFMp_--BAdizs2arRB-uzSCctrgcEks5qIZK2gaJpZM4IuAcT">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFE8Z7enbbCmDQK4IPAVFxNixZ8n-ks5qIZK2gaJpZM4IuAcT.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/675#issuecomment-223760088"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>