<p>In <a href="https://github.com/mlpack/mlpack/pull/664#discussion_r65640119">src/mlpack/core/tree/rectangle_tree/discrete_hilbert_value_impl.hpp</a>:</p>
<pre style='color:#555'>> + for(std::list<arma::Col<uint64_t>>::iterator it = otherDataset->begin(); it != otherDataset->end(); it++)
> + {
> + localDataset->push_back(*it);
> + }
> + largestValue = localDataset->end();
> + if(otherDataset->size() > 0)
> + largestValue--;
> + }
> +}
> +
> +template<typename ElemType>
> +arma::Col<uint64_t> DiscreteHilbertValue::
> +CalculateValue(const arma::Col<ElemType> &pt)
> +{
> + arma::Col<uint64_t> res(pt.n_rows);
> + constexpr int order = 64; // The number of bits that we can store
</pre>
<p>Hm, is this the right order if ElemType is a float? Or should we be using <code>uint32_t</code> in that case? It would not be too hard to do a little template metaprogramming to figure out the right type to use (<code>uint32_t</code> or <code>uint64_t</code>), but I am not 100% sure if the order should be 32 if ElemType is a float, you would know better than me.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/664/files/ab890dff6b4b617b5309af53950c6cac97d994d6#r65640119">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFF1UHdGjf7gPBw_7BVOM-c49h_IRks5qH3EDgaJpZM4IrlzT">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFKwCCVcIIwuuHLYnCSBpgA1we2Giks5qH3EDgaJpZM4IrlzT.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/664/files/ab890dff6b4b617b5309af53950c6cac97d994d6#r65640119"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>