<p>In <a href="https://github.com/mlpack/mlpack/pull/664#discussion_r65641137">src/mlpack/core/tree/rectangle_tree/discrete_hilbert_value.hpp</a>:</p>
<pre style='color:#555'>> + DiscreteHilbertValue();
> +
> + /**
> + * Construct this for the node tree. If the node is the root this method
> + * computes the Hilbert value for each point in the tree's dataset.
> + * @param node The node that stores this Hilbert value.
> + */
> + template<typename TreeType>
> + DiscreteHilbertValue(const TreeType *tree);
> +
> + /**
> + * Create a Hilbert value object by copying from the other node.
> + * @param other The node from which the value will be copied.
> + */
> + template<typename TreeType>
> + DiscreteHilbertValue(const TreeType &other);
</pre>
<p>This looks like a copy constructor, should it take a <code>const DiscreteHilbertValue&</code> instead of a <code>TreeType&</code>?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/664/files/ab890dff6b4b617b5309af53950c6cac97d994d6#r65641137">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFO4RWwzDOG6liwvScVVuLSzJr4Vgks5qH3QbgaJpZM4IrlzT">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFFNpuDb1vShEs4qUaCcwyuyYI15qks5qH3QbgaJpZM4IrlzT.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/664/files/ab890dff6b4b617b5309af53950c6cac97d994d6#r65641137"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>