<p>In <a href="https://github.com/mlpack/mlpack/pull/663#discussion_r65260027">src/mlpack/methods/lsh/lsh_search.hpp</a>:</p>
<pre style='color:#555'>> */
> void Train(const arma::mat& referenceSet,
> const size_t numProj,
> const size_t numTables,
> const double hashWidth = 0.0,
> const size_t secondHashSize = 99901,
> - const size_t bucketSize = 500);
> + const size_t bucketSize = 500,
> + const std::vector<arma::mat> &projection
> + = std::vector<arma::mat>()
</pre>
<p>Do you think we could use <code>arma::cube</code> here instead? We know how many projection tables we have and how many projections are in each table (and it's the same number of projections per table), so we don't need the extra overhead of the vector. I know that's not code you wrote, but I wanted to ask if you think we could make that change (I'll do it if you think it's reasonable, unless you beat me to it :)).</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/663/files/934fe082230f7d8b8f9c3e9c1fe2f9fc25ea493e#r65260027">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFGtnkJZE48_BZjfXbDm9Ss0jdjvJks5qHJ7ugaJpZM4Iq6tl">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFP2hVMDhknmZEt2bmoYfynB1Gh_Gks5qHJ7ugaJpZM4Iq6tl.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/663/files/934fe082230f7d8b8f9c3e9c1fe2f9fc25ea493e#r65260027"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>