<p>First version of Multiprobe LSH. It is possible GetAdditionalProbingBins() can be further optimized.</p>
<p>I ended up using the initial code that allocated more memory and used find() to create the candidate set - I could change that to allocating less memory and using unique() instead, as I proposed in PR <a href="https://github.com/mlpack/mlpack/pull/623" class="issue-link js-issue-link" data-url="https://github.com/mlpack/mlpack/issues/623" data-id="148877223" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#623</a>.</p>
<p>More eyes on this might be beneficial so I am submitting a PR.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/mlpack/mlpack/pull/657'>https://github.com/mlpack/mlpack/pull/657</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Implements GetAdditionalQueryBins</li>
<li>First working version, requires more testing</li>
<li>First working version, requires more testing</li>
<li>Fix minor bug causing freeze when too many probes were requested</li>
<li>Adds ComputeRecall and changes lsh_main.cpp to call it if truth file is specified</li>
<li>Fixes regression in ReturnIndicesFromTables that caused segfaults</li>
<li>Fixes regression in ReturnIndicesFromTables that caused segfaults</li>
<li>Prevents perturbation sets with invalid dimensions to be created</li>
<li>Adds multiprobe test</li>
<li>Adds multiprobe test</li>
<li>Documents ComputeRecall</li>
<li>Style Fixes</li>
<li>Style Fixes</li>
<li>Merge branch 'master' of https://github.com/mlpack/mlpack into MultiprobeLSH</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/657/files#diff-0">src/mlpack/methods/lsh/lsh_main.cpp</a>
(22)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/657/files#diff-1">src/mlpack/methods/lsh/lsh_search.hpp</a>
(31)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/657/files#diff-2">src/mlpack/methods/lsh/lsh_search_impl.hpp</a>
(352)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/657/files#diff-3">src/mlpack/tests/lsh_test.cpp</a>
(67)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/mlpack/mlpack/pull/657.patch'>https://github.com/mlpack/mlpack/pull/657.patch</a></li>
<li><a href='https://github.com/mlpack/mlpack/pull/657.diff'>https://github.com/mlpack/mlpack/pull/657.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/657">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFILxMlrdQmhhjc6mXuZ_xui_oagQks5qGbavgaJpZM4IpUVp">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFHO0FJcZUQ8L7hafnE8eEYWXKwLeks5qGbavgaJpZM4IpUVp.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/657"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>