<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>&nbsp;&nbsp;<a href='https://github.com/mlpack/mlpack/pull/655'>https://github.com/mlpack/mlpack/pull/655</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix error, a balltree should use ballbounds instead of hrectbounds.</li>
  <li>Set proper template order. To work with binary space trees, the metric template parameter must be the first.</li>
  <li>Proper template order to BallBound.</li>
  <li>Fix error. kdtree where should be a balltree.</li>
  <li>Change template name to be similar to the definition of hrectbound.</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/655/files#diff-0">src/mlpack/core/tree/ballbound.hpp</a>
    (20)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/655/files#diff-1">src/mlpack/core/tree/ballbound_impl.hpp</a>
    (94)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/655/files#diff-2">src/mlpack/core/tree/binary_space_tree/typedef.hpp</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/655/files#diff-3">src/mlpack/methods/neighbor_search/ns_model_impl.hpp</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/mlpack/mlpack/pull/655/files#diff-4">src/mlpack/tests/serialization_test.cpp</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/mlpack/mlpack/pull/655.patch'>https://github.com/mlpack/mlpack/pull/655.patch</a></li>
  <li><a href='https://github.com/mlpack/mlpack/pull/655.diff'>https://github.com/mlpack/mlpack/pull/655.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/655">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFEmuqSa7a8r9y4X095LFZ5sSLbwPks5qF4usgaJpZM4Io86t">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFNV86aMhGFQS2ELUWS1thyel1LtYks5qF4usgaJpZM4Io86t.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/655"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>