<p>In <a href="https://github.com/mlpack/mlpack/pull/523#discussion_r60099273">src/mlpack/core/util/split_data.hpp</a>:</p>
<pre style='color:#555'>&gt; +                    arma::Row&lt;U&gt; &amp;testLabel,
&gt; +                    double const testRatio)
&gt; +{
&gt; +  size_t const testSize =
&gt; +      static_cast&lt;size_t&gt;(input.n_cols * testRatio);
&gt; +  size_t const trainSize = input.n_cols - testSize;
&gt; +  trainData.set_size(input.n_rows, trainSize);
&gt; +  testData.set_size(input.n_rows, testSize);
&gt; +  trainLabel.set_size(trainSize);
&gt; +  testLabel.set_size(testSize);
&gt; +
&gt; +  using Col = arma::Col&lt;size_t&gt;;
&gt; +  Col const sequence = arma::linspace&lt;Col&gt;(0, input.n_cols - 1,
&gt; +                                           input.n_cols);
&gt; +  arma::Col&lt;size_t&gt; const order = arma::shuffle(sequence);
&gt; +
</pre>
<p>Okay, another highly biased and all in all picky comment from my side. I would combine line 53-56 into a single line. We don't need to store <code>sequence</code> right?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly or <a href="https://github.com/mlpack/mlpack/pull/523/files/c92dd2fc6561b1cf40efb744dcc9233bc3675c91#r60099273">view it on GitHub</a><img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFNX4bBnnN0kSynZIkQN502Xvlo9zks5p479xgaJpZM4HhWF3.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/523/files/c92dd2fc6561b1cf40efb744dcc9233bc3675c91#r60099273"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>