<p>In <a href="https://github.com/mlpack/mlpack/pull/556#discussion_r58482410">src/mlpack/core/tree/rectangle_tree/rectangle_tree.hpp</a>:</p>
<pre style='color:#555'>> @@ -76,6 +76,9 @@ class RectangleTree
> } SplitHistoryStruct;
>
> private:
> + //! The max number of child nodes a non-leaf normal node can have.
> + //! (used in x-trees)
> + size_t normalNodeMaxNumChildren;
</pre>
<p>I don't like putting X tree logic in the generic RectangleTree class; I think maybe the right thing here is some refactoring. I wonder if maybe <code>CondenseTree()</code> should call some function in <code>SplitType</code>. But probably the refactoring that has to happen to make this work is pretty significant, so if you can't think of something now we can open a ticket and save it for some other time. I read through <code>CondenseTree()</code> but it was only a quick read and I didn't think of any easy solutions for refactoring this x-tree logic out. Any ideas?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly or <a href="https://github.com/mlpack/mlpack/pull/556/files/1ed8c18dedb54772377c17ff48f2b313792feb0f#r58482410">view it on GitHub</a><img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFJOdTr8xrV0cm1l6xm5J6r2iHVcCks5p0daygaJpZM4HsSai.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/556/files/1ed8c18dedb54772377c17ff48f2b313792feb0f#r58482410"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>