<p>In <a href="https://github.com/mlpack/mlpack/pull/388#discussion_r23583442">src/mlpack/methods/mean_shift/mean_shift.hpp</a>:</p>
<pre style='color:#555'>> +{
> + public:
> + /**
> + * Create a Mean Shift object and set the parameters which Mean Shift
> + * will be run with.
> + *
> + * @param duplicateThresh If distance of two centroids is less than it, one will be removed.
> + * @param maxIterations Maximum number of iterations allowed before giving up
> + * @param stopThresh If the 2-norm of the mean shift vector is less than stopThresh,
> + * iterations will terminate.
> + * @param kernel Optional KernelType object.
> + */
> + MeanShift(const double duplicateThresh = 1.0,
> + const size_t maxIterations = 1000,
> + const double stopThresh = 1e-3,
> + const KernelType kernel = KernelType());
</pre>
<p>I don't think that the duplicate threshold should have a default, because the value that should be used is completely dependent on the dataset. I don't mind putting in some basic logic to estimate a threshold value if the user does not specify one, but a default of 1.0 is a bad idea, in my opinion. (If you think I'm wrong, please feel free to provide a rebuttal.)</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/mlpack/mlpack/pull/388/files#r23583442">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFKVgbaI7YrzBTesQrtDJDDHHelk2ks5nlu-lgaJpZM4DTzb1.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/388/files#r23583442"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>