<p>In <a href="https://github.com/mlpack/mlpack/pull/374#discussion-diff-22744211">src/mlpack/methods/matrix_completion/matrix_completion_impl.hpp</a>:</p>
<pre style='color:#555'>> +
> +MatrixCompletion::MatrixCompletion(const size_t m,
> + const size_t n,
> + const arma::umat& indices,
> + const arma::vec& values)
> + : m(m), n(n), indices(indices), values(values),
> + sdp(indices.n_cols, 0, CreateInitialPoint(m, n, DefaultRank(m, n, indices.n_cols)))
> +{
> + checkValues();
> + initSdp();
> +}
> +
> +void MatrixCompletion::checkValues()
> +{
> + if (indices.n_rows != 2)
> + Log::Fatal << "indices.n_rows != 2" << std::endl;
</pre>
<p>Can you make these error messages more descriptive? Should a user come up against this (say they are using CF or something), they're just going to see</p>
<pre><code>[FATAL] indices.n_rows != 2
</code></pre>
<p>and confusion will reign forever. Probably <code>MatrixCompletion::MatrixCompletion(): matrix of indices for constraints does not have two rows.</code> or something similar will be better. Alternately, I am beginning to think that <code>Log::Fatal</code> calls should produce a backtrace, but I want to let the idea simmer more before opening an issue or doing something about it (getting backtraces is not always easy, and I don't think the code we have in place for <code>Log::Assert</code> is very robust).</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/mlpack/mlpack/pull/374/files#r22744211">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFEOFu3zNG-HP_dlA_VWa8JoXVggwks5ngD8BgaJpZM4DOLPX.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/374/files#r22744211"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>