[mlpack-git] [mlpack/mlpack] Attempt to fix failing build for old Armadillo versions. (310e72d)

[Conrad Sanderson]

I'm not sure this is necessary, due to the reasons listed below. In fact, I'd argue it's actually counterproductive. Using + and % instead of || and && makes the code harder to interpret and less efficient.

Reasoning is as follows. MLPACK requires a C++11 compiler.  The lowest version of gcc with sufficient C++11 support is gcc 4.8, which is in both Ubuntu 14.04 and RHEL 7.  Ubuntu 14.04 has Armadillo 4.200, while RHEL 7 uses EPEL 7, which currently has Armadillo 4.320 (... nudge, nudge).

Support for && and || operators is present in Armadillo 4.200.

https://launchpad.net/ubuntu/+source/armadillo/
https://apps.fedoraproject.org/packages/armadillo-devel


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/commit/310e72d7afeb952bb08a0d0dabf16cc605178528#commitcomment-19096436
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160920/545f56a6/attachment-0001.html>