[mlpack-git] [mlpack/mlpack] CoverTreeAlternateMetricTest occasionally fails (#357)

Ryan Curtin notifications at github.com
Thu Sep 15 11:25:32 EDT 2016

It turns out there is no need to check the separation invariant.  In the long version of the cover tree paper (https://hunch.net/~jl/projects/cover_tree/paper/paper.pdf), they write that for implementation they take a few shortcuts, including:

> We relax the separation invariant in batch construction.

So, since the mlpack cover tree code is based heavily on the original cover tree code, the separation invariant is also relaxed in mlpack, and there is no need to test for it.  3f5503b removes the test and fixes the issue.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160915/dd46ae58/attachment.html>

More information about the mlpack-git mailing list