[mlpack-git] [mlpack/mlpack] Density Estimation Tree made sparse-enabled (#802)

Ryan Curtin notifications at github.com
Tue Oct 25 22:27:52 EDT 2016


rcurtin commented on this pull request.



> @@ -4,11 +4,7 @@
 set(SOURCES
   # the DET class
   dtree.hpp
-  dtree.cpp
-
-  # the util file
-  dt_utils.hpp
-  dt_utils.cpp
+  dtree_impl.hpp

Yes, they actually can be used for the library---they contain some cross-validation code and the `Trainer()` method which is used for producing a cross-validated tree.  To be honest I would prefer if those were refactored into the class constructor itself, since they are not very "mlpack-ish", but either way they are something that a user may want to use so we should leave them in.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/802
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20161025/84cfca8c/attachment.html>


More information about the mlpack-git mailing list