[mlpack-git] [mlpack/mlpack] Density Estimation Tree made sparse-enabled (#802)

Ryan Curtin notifications at github.com
Wed Oct 19 17:38:01 EDT 2016


rcurtin commented on this pull request.



> @@ -4,11 +4,7 @@
 set(SOURCES
   # the DET class
   dtree.hpp
-  dtree.cpp
-
-  # the util file
-  dt_utils.hpp
-  dt_utils.cpp
+  dtree_impl.hpp

Shouldn't we include `dt_utils.hpp` and `dt_utils_impl.hpp` too?  I overlooked this in my review :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/802#pullrequestreview-4966993
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20161019/fb77f340/attachment.html>


More information about the mlpack-git mailing list