[mlpack-git] [mlpack/mlpack] Put all singletons in libmlpack.so (#800)

[Ryan Curtin]

This is a solution for #524.  It actually functions about the same as that solution but creates a separate file for singletons (`src/mlpack/core/singletons.cpp`).  As a result of this change it is possible to create a program that has `#include <mlpack/core.hpp>` without linking against libmlpack.so, if no mlpack symbols are used.  This was not possible before.

I'll leave this for a couple of days before I merge it.

@theSundayProgrammer: I know this took a very long time for me to get around to, but here is (finally) a solution.  Like I said it is essentially equivalent to yours, just arranged differently.
You can view, comment on, or merge this pull request online at:

  https://github.com/mlpack/mlpack/pull/800

-- Commit Summary --

  * Refactor singletons into one .cpp file.
  * Add clarifying comment.

-- File Changes --

    M src/mlpack/core/util/CMakeLists.txt (2)
    M src/mlpack/core/util/cli.cpp (2)
    M src/mlpack/core/util/cli_deleter.hpp (5)
    M src/mlpack/core/util/log.cpp (32)
    A src/mlpack/core/util/singletons.cpp (50)
    A src/mlpack/core/util/singletons.hpp (21)

-- Patch Links --

https://github.com/mlpack/mlpack/pull/800.patch
https://github.com/mlpack/mlpack/pull/800.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/800
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20161011/bc1333fe/attachment.html>