[mlpack-git] master: make TransPoseTokens as rcurtin suggested, should not use nameless namespace in header file (3e75b48)

gitdub at mlpack.org gitdub at mlpack.org
Tue May 31 14:44:10 EDT 2016


Repository : https://github.com/mlpack/mlpack
On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/2629a4fd65684e2bd4544d5ef8ea07fa9ad594a7...ee95e2030ddd526368e377b4e1c13484d471e307

>---------------------------------------------------------------

commit 3e75b485bf78db28e4b38437b0fe0bda00736fb4
Author: stereomatchingkiss <stereomatchingkiss at gmail.com>
Date:   Wed Jun 1 02:44:10 2016 +0800

    make TransPoseTokens as rcurtin suggested, should not use nameless namespace in header file


>---------------------------------------------------------------

3e75b485bf78db28e4b38437b0fe0bda00736fb4
 src/mlpack/core/data/load_impl.hpp | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/mlpack/core/data/load_impl.hpp b/src/mlpack/core/data/load_impl.hpp
index 8f29837..5479bab 100644
--- a/src/mlpack/core/data/load_impl.hpp
+++ b/src/mlpack/core/data/load_impl.hpp
@@ -31,8 +31,6 @@ namespace data {
 
 namespace details{
 
-namespace{
-
 template<typename Tokenizer>
 std::vector<std::string> ToTokens(Tokenizer &lineTok)
 {
@@ -49,6 +47,7 @@ std::vector<std::string> ToTokens(Tokenizer &lineTok)
   return tokens;
 }
 
+inline
 void TransPoseTokens(std::vector<std::vector<std::string>> const &input,
                      std::vector<std::string> &output,
                      size_t index)
@@ -99,8 +98,6 @@ void MapToNumerical(const std::vector<std::string> &tokens,
 
 }
 
-}
-
 template<typename eT>
 bool inline inplace_transpose(arma::Mat<eT>& X)
 {




More information about the mlpack-git mailing list