[mlpack-git] master: use algorithm to replace for loop (9aac1dc)

gitdub at mlpack.org gitdub at mlpack.org
Tue May 31 04:19:18 EDT 2016


Repository : https://github.com/mlpack/mlpack
On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/2629a4fd65684e2bd4544d5ef8ea07fa9ad594a7...ee95e2030ddd526368e377b4e1c13484d471e307

>---------------------------------------------------------------

commit 9aac1dca04dbfbd63658f0719a97aea6804cae2d
Author: stereomatchingkiss <stereomatchingkiss at gmail.com>
Date:   Tue May 31 16:19:18 2016 +0800

    use algorithm to replace for loop


>---------------------------------------------------------------

9aac1dca04dbfbd63658f0719a97aea6804cae2d
 src/mlpack/core/data/load_impl.hpp | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/mlpack/core/data/load_impl.hpp b/src/mlpack/core/data/load_impl.hpp
index 69a46fa..c74b089 100644
--- a/src/mlpack/core/data/load_impl.hpp
+++ b/src/mlpack/core/data/load_impl.hpp
@@ -402,12 +402,14 @@ bool Load(const std::string& filename,
       std::vector<std::string> tokens;
       if(!transpose)
       {
-        for (Tokenizer::iterator it = lineTok.begin(); it != lineTok.end(); ++it)
+        std::transform(std::begin(lineTok), std::end(lineTok),
+                       std::back_inserter(tokens),
+                       [&tokens](std::string const &str)
         {
-          std::string trimmedToken(*it);
+          std::string trimmedToken(str);
           boost::trim(trimmedToken);
-          tokens.emplace_back(std::move(trimmedToken));
-        }
+          return std::move(trimmedToken);
+        });
         bool const notNumeric = std::any_of(std::begin(tokens),
                                            std::end(tokens), notNumber);
         if(notNumeric)




More information about the mlpack-git mailing list