[mlpack-git] [mlpack/mlpack] Lsh table access (#663)

[Ryan Curtin]

> @@ -188,7 +210,7 @@ class LSHSearch
>     * are private members of this class, initialized during the class
>     * initialization.
>     */
> -  void BuildHash();
> +  void BuildHash(const std::vector<arma::mat> &projection);

If you set `LSHSearch::projections` in either the constructor or in `Train()` then there is no need to pass this parameter (or check its validity inside of `BuildHash()`).  Actually to be honest I would be happy to move `BuildHash()` entirely into `Train()` since `BuildHash()` is only called once, but either way is fine.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/663/files/934fe082230f7d8b8f9c3e9c1fe2f9fc25ea493e#r65260843
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160531/d8718662/attachment.html>