[mlpack-git] [mlpack/mlpack] Default to DEBUG=OFF and PROFILE=OFF. (#662)

Ryan Curtin notifications at github.com
Tue May 31 15:04:37 EDT 2016


This is because people are using mlpack from git and wondering why it is so
slow.

This issue came to my attention because I came across this paper:
http://arxiv.org/abs/1602.02514
and in the revision I read (the first or probably the second revision on arXiv), I found that the numbers for mlpack were extremely slow.  After consulting with the author it turned out he had just compiled as-is off Github, with debugging symbols and all.  So I think maybe compiling without debugging symbols by default will be helpful for people who just want to use mlpack, and don't bother to look into how to configure it, and then wonder why mlpack is so slow.

I'm opening this as a PR for discussion, because there are advantages and disadvantages to this.  Once we reach some consensus we can make a decision.  So I'm for the change (which makes sense because I opened the PR :)).
You can view, comment on, or merge this pull request online at:

  https://github.com/mlpack/mlpack/pull/662

-- Commit Summary --

  * Default to DEBUG=OFF and PROFILE=OFF.

-- File Changes --

    M CMakeLists.txt (4)

-- Patch Links --

https://github.com/mlpack/mlpack/pull/662.patch
https://github.com/mlpack/mlpack/pull/662.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/662
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160531/d9172e53/attachment.html>


More information about the mlpack-git mailing list