[mlpack-git] [mlpack/mlpack] GMM Serialization function incorrectly named. (#644)

[TCatshoek]

First of all, I'm rather new to c++ so forgive me if this is a misunderstanding on my part.

When attempting to serialize mlpack::gmm::GMM both boost serialization and cereal are unable to find a serialization function. From gmm.hpp:

```
/**
   * Serialize the GMM.
   */
  template<typename Archive>
  void Serialize(Archive& ar, const unsigned int /* version */);
```

So the function is there, but it is named Serialize with a capital S while both boost and cereal expect it to start with a lowercase s. I changed the function declaration to:

```
/**
   * Serialize the GMM.
   */
  template<class Archive>
  void serialize(Archive& ar, const unsigned int version);
```

Along with the corresponding edits in gmm_impl.hpp, and now it works fine with boost serialization. I have not tested it with cereal, but i assume it should work there too. 

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/644
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160524/a5c91afb/attachment.html>